Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate gRPC clients for all SDKs. #2727

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Regenerate gRPC clients for all SDKs. #2727

merged 1 commit into from
Sep 3, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

  • Realised the instructions where wrong. It should be make gen-all-sdk-grpc (we should document this).
  • Also updated the CPP SDK to 1.36.1.

Which issue(s) this PR fixes:

Work on #2642

Special notes for your reviewer:

Making a note we should update kubernetes_update.md with updating gRPC version details.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Sep 3, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f450abd3-dbc8-4e8f-9fdf-16c53c756532

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

gah

--- FAIL: TestFleetRollingUpdate (0.00s)
    --- FAIL: TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true (94.14s)
        fleet_test.go:413: 
            	Error Trace:	fleet_test.go:413
            	Error:      	Condition never satisfied
            	Test:       	TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true
time="2022-09-03 00:45:24.316" level=info msg="Checking Fleet Ready replicas" expected=1 fl

flakiness.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 875dcce7-6e5c-4fa0-877a-22b97f186b19

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Regenerate gRPC clients for all SDKs.
a795717 
* Realised the instructions where wrong. It should be
  `make gen-all-sdk-grpc` (we should document this).
* Also updated the CPP SDK to 1.36.1.

Work on googleforgames#2642
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5ed2b03a-246c-49ba-ac93-9e31840b874e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2727/head:pr_2727 && git checkout pr_2727
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-a795717-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Sep 3, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 94de5b0 into googleforgames:main Sep 3, 2022
@SaitejaTamma SaitejaTamma added this to the 1.26.0 milestone Sep 6, 2022
@markmandel markmandel deleted the grpc/update-sdks branch September 6, 2022 19:21
@roberthbailey roberthbailey mentioned this pull request Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@devjgm devjgm Awaiting requested review from devjgm

@EricFortin EricFortin Awaiting requested review from EricFortin

@steven-supersolid steven-supersolid Awaiting requested review from steven-supersolid

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XXL
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @roberthbailey @SaitejaTamma